Re: [PATCH 01/13] tracing: Extract duplicateftrace_raw_init_event_foo()

[Frederic Weisbecker]

On Tue, Dec 08, 2009 at 03:49:29PM +0800, Li Zefan wrote:
> >> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
> >> index e79e2f3..55e7108 100644
> >> --- a/include/linux/syscalls.h
> >> +++ b/include/linux/syscalls.h
> >> @@ -144,7 +144,7 @@ struct perf_event_attr;
> >>  		.name                   = "sys_enter"#sname,		\
> >>  		.system                 = "syscalls",			\
> >>  		.event                  = &enter_syscall_print_##sname,	\
> >> -		.raw_init		= init_syscall_trace,		\
> >> +		.raw_init		= trace_event_raw_init,		\
> >>  		.show_format		= syscall_enter_format,		\
> >>  		.define_fields		= syscall_enter_define_fields,	\
> >>  		.regfunc		= reg_event_syscall_enter,	\
> >> @@ -166,7 +166,7 @@ struct perf_event_attr;
> >>  		.name                   = "sys_exit"#sname,		\
> >>  		.system                 = "syscalls",			\
> >>  		.event                  = &exit_syscall_print_##sname,	\
> >> -		.raw_init		= init_syscall_trace,		\
> >> +		.raw_init		= trace_event_raw_init,		\
> > 
> > 
> > 
> > Nice cleanup.
> > BTW, init_syscall_trace is left unused now. Could you please
> > remove it too?
> > 
> 
> I'd like to see the whole patchset be accepted first. I don't
> won't to spam LKML with another 14 emails. ;)



You can just answer the pervious patch with a new one, putting
a v2 prefix in the title :)


 
> Though I can just resend this patch, Ingo might be confused
> which patch he should take.
> 
> btw, Lai Jiangshan just told me he has a pending patch that
> will modify init_syscall_trace, so init_syscall_trace will
> come back to use again.


Ah ok.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/