Re: + task_struct-make-journal_info-conditional.patch added to -mmtree

[Hiroshi Shimamoto]

Ryusuke Konishi wrote:
>> Alexey Dobriyan wrote:
>>> On Fri, Dec 04, 2009 at 12:58:06PM +0900, Hiroshi Shimamoto wrote:
>>>> Alexey Dobriyan wrote:
>>>>> On Thu, Dec 03, 2009 at 02:40:57PM -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
>>>>>> --- a/include/linux/sched.h~task_struct-make-journal_info-conditional
>>>>>> +++ a/include/linux/sched.h
>>>>>> @@ -1452,8 +1452,10 @@ struct task_struct {
>>>>>>  	gfp_t lockdep_reclaim_gfp;
>>>>>>  #endif
>>>>>>  
>>>>>> +#ifdef CONFIG_FS_JOURNAL_INFO
>>>>>>  /* journalling filesystem info */
>>>>>>  	void *journal_info;
>>>>>> +#endif
>>>>> This will prevent using e.g. ext3 on CONFIG_EXT3_FS=n kernels.
>>>> I'm sorry, I'm not sure what you're mentioning.
>>> With this patch admin must decide in advance if he will ever use ext3.
>>> EXT3_FS=n kernels won't be able to get ext3 support without reboot
>>> even as module, because task_struct will be different.
>> I see, you want to keep this field for future use even if EXT3_FS=n.
>> I think, however, there might be a need to remove this because the user
>> never enable any journaling filesystem.
> 
> Do you have some background to remove the "void *" from task_struct?
> You need it for embedded purpose?

Yeah, it's for embedded. I think it's good if there is a option to make
memory usage small.

Thanks,
Hiroshi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/