Re: DRM/ttm: Unreachable code in ttm_bo_add_ttm

[Dave Airlie]

On Mon, 7 Dec 2009, Jiri Slaby wrote:

> Hi,
> 
> Stanse found unreachable code in ttm_bo_add_ttm:
> http://decibel.fi.muni.cz/~xslaby/stanse/error.cgi?db=32&id=714#l238
> 
> Excerpt from there:
>   230| case ttm_bo_type_user:
>   231|  bo->ttm = ttm_tt_create(bdev, bo->num_pages << 12,
>   232|     page_flags | (1 << 1),
>   233|     glob->dummy_read_page);
>   234|  if (bo->ttm == ((void *)0))
>   235|   ret = -12;
>   236|  break;
>   237|
>   238|  ret = ttm_tt_set_user(bo->ttm, get_current(),
>      |This node is unreachable prev next
>   239|          bo->buffer_start, bo->num_pages);
>   240|  if (ret != 0)
>   241|   ttm_tt_destroy(bo->ttm);
>   242|  break;
> 
> 

Thanks,
I've pushed this patch.