Re: [PATCH v2 1/4] copy_signal cleanup: use zalloc and removeinitializations

From: Andrew Morton
Date: Mon Dec 07 2009 - 15:37:24 EST


On Fri, 4 Dec 2009 15:28:14 +0100
Veaceslav Falico <vfalico@xxxxxxxxxx> wrote:

> Use kmem_cache_zalloc() on signal creation and remove unneeded initialization
> lines in copy_signal().
>
> Signed-off-by: Veaceslav Falico <vfalico@xxxxxxxxxx>
> ---
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 166b8c4..160477d 100644
> @@ -855,7 +844,7 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk)

For some reason this patch is missing its headers and doesn't apply.

I fixed that up and it still doesn't apply, because there are pending
changes in this area in -mm.

Normally I'd fix that up, but this one is looking a bit non-trivial, so
I'm afraid I'm going to ask you to redo the patches against
http://userweb.kernel.org/~akpm/mmotm/

Alternatively, we could just hold them off until 2.6.34. Wait until
2.6.33-rc1 is released then resend the patch series based on
2.6.33-rc1. Perhaps this is a better approach, as we are now in the
2.6.33 merge window and it's a bit late to be introducing new material.

Either way, please do ensure that the next patch series retains all the
acked-by:'s which people have sent.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/