Re: [Patch] proc: fill 'lib' field in /proc/<pid>/statm

[Cong Wang]

Hugh Dickins wrote:
> On Mon, 7 Dec 2009, Amerigo Wang wrote:
>
> > Currently, the 'lib' field of /proc/<pid>/statm is
> > always 0, we should fill it with the right value,
> > the same with 'VmLib'.
>
> The right value (if you're looking for consistency with Linux 2.4)
> is the number of currently resident "library" pages: and we don't
> know that number - we can't even define what a library is.

Hmm, the current algorithm is just kicking out text size of itself
from ->exec_vm, it really makes some sense, but not always.

> We could add some code to make it show the same bogus number as
> we show somewhere else, but it has said 0 ever since 2.5.37: so
> I don't think it's worth a line of code myself, but bow to others.


If you mean 'VmLib' in /proc/<pid>/status, this is the same with it.

> > Signed-off-by: WANG Cong <amwang@xxxxxxxxxx>
> > Cc: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
> > Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> > Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > Cc: Mel Gorman <mel@xxxxxxxxx>
> > Cc: stable@xxxxxxxxxx
>
> What does alarm me is that you think this is fit for -stable!

Oh, sorry, I thought missing this field is a mistake...
Dropped.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/