Re: [PATCH 28/31] Constify struct super_operations for 2.6.32 v1

[Al Viro]

On Fri, Dec 04, 2009 at 11:47:15PM +0100, Emese Revfy wrote:
> From: Emese Revfy <re.emese@xxxxxxxxx>
> 
> Constify struct super_operations.

What the _hell_ is that?

> +   	struct inode *(* const alloc_inode)(struct super_block *sb);

This is ugly and has all marks of cargo-cult patches.  NAKed at least
until you give exceptionally good reasons for doing that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/