Re: [stable] x86: Remove STACKPROTECTOR_ALL

[Greg KH]

On Wed, Nov 11, 2009 at 12:23:16AM +0200, Thomas Backlund wrote:
> I think this one should go to 2.6.31.x too ...
> 
> > Gitweb:     http://git.kernel.org/linus/14a3f40aafacde1dfd6912327ae14df4baf10304
> > Commit:     14a3f40aafacde1dfd6912327ae14df4baf10304
> > Parent:     02dd0a0613e0d84c7dd8315e3fe6204d005b7c79
> > Author:     Arjan van de Ven <arjan@xxxxxxxxxxxxx>
> > AuthorDate: Fri Oct 23 07:31:01 2009 -0700
> > Committer:  Ingo Molnar <mingo@xxxxxxx>
> > CommitDate: Fri Oct 23 16:35:23 2009 +0200
> > 
> >     x86: Remove STACKPROTECTOR_ALL
> >     
> >     STACKPROTECTOR_ALL has a really high overhead (runtime and stack
> >     footprint) and is not really worth it protection wise (the
> >     normal STACKPROTECTOR is in effect for all functions with
> >     buffers already), so lets just remove the option entirely.
> >     
> >     Reported-by: Dave Jones <davej@xxxxxxxxxx>
> >     Reported-by: Chuck Ebbert <cebbert@xxxxxxxxxx>
> >     Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> >     Cc: Eric Sandeen <sandeen@xxxxxxxxxx>
> >     LKML-Reference: <20091023073101.3dce4ebb@xxxxxxxxxxxxx>
> >     Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

It doesn't really "fix" anything, so I'd prefer not too.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/