Re: [PATCH v2] PCI: Always set prefetchable base/limit upper32registers

From: Alex Williamson
Date: Sat Dec 05 2009 - 09:50:09 EST


On Fri, 2009-12-04 at 16:01 -0800, Jesse Barnes wrote:
> On Mon, 30 Nov 2009 14:51:44 -0700
> Alex Williamson <alex.williamson@xxxxxx> wrote:
>
> > Prior to 1f82de10 we always initialized the upper 32bits of the
> > prefetchable memory window, regardless of the address range used.
> > Now we only touch it for a >32bit address, which means the upper32
> > registers remain whatever the BIOS initialized them too.
> >
> > It's valid for the BIOS to set the upper32 base/limit to
> > 0xffffffff/0x00000000, which makes us program prefetchable ranges
> > like 0xffffffffabc00000 - 0x00000000abc00000
> >
> > Revert the chunk of 1f82de10 that made this conditional so we always
> > write the upper32 registers and remove now unused pref_mem64 variable.
> >
> > Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>
> > ---
> >
>
> Applied this one, though it looks like your diff had some context that
> wasn't in my tree. Please double check that I fixed it up correctly.

Yep, looks fine. Thanks Jesse.

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/