Re: [PATCH 05/31] Constify struct dma_map_ops for 2.6.32 v1

[Stephen Rothwell]

Hi Emese,

On Sat, 05 Dec 2009 03:25:23 +0100 Emese Revfy <re.emese@xxxxxxxxx> wrote:
>
> I already took care of these, look at these hunks:
> 
> @@ -1033,7 +1026,6 @@ int vio_cmo_entitlement_update(size_t new_entitlement) { return 0; }
>  void vio_cmo_set_dev_desired(struct vio_dev *viodev, size_t desired) {}
>  static int vio_cmo_bus_probe(struct vio_dev *viodev) { return 0; }
>  static void vio_cmo_bus_remove(struct vio_dev *viodev) {}
> -static void vio_cmo_set_dma_ops(struct vio_dev *viodev) {}
>  static void vio_cmo_bus_init(void) {}
>  static void vio_cmo_sysfs_init(void) { }
>  #endif /* CONFIG_PPC_SMLPAR */
> @@ -1233,7 +1225,7 @@ struct vio_dev *vio_register_device_node(struct device_node *of_node)
>  	viodev->dev.archdata.of_node = of_node_get(of_node);
>  
>  	if (firmware_has_feature(FW_FEATURE_CMO))
> -		vio_cmo_set_dma_ops(viodev);
> +		viodev->dev.archdata.dma_ops = &vio_dma_mapping_ops;

This code is not inside a #ifdef CONFIG_PPC_SMLPAR section, so
vio_dma_mapping_ops may not exist here.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature