Re: [PATCH 05/24] ceph: ref counted buffer

From: Ingo Oeser
Date: Fri Dec 04 2009 - 20:31:56 EST


On Friday 04 December 2009, Sage Weil wrote:
> struct ceph_buffer is a simple ref-counted buffer. We transparently
> choose between kmalloc for small buffers and vmalloc for large ones.
>
> This is currently used only for allocating memory for xattr data.

Could you wrap parts of this refcounting logic around kref?
see #include <linux/kref.h> and lib/kref.c

It avoids a bug with memory areas for free and if anybody
optimizes or changes refcounting stuff, you get all changes for free :-)

Best Regards

Ingo Oeser
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/