Re: [PATCH 2/9] ksm: let shared pages be swappable
From: Rik van Riel
Date: Fri Dec 04 2009 - 11:21:58 EST
On 12/04/2009 09:45 AM, Andrea Arcangeli wrote:
I think it's fishy to ignore the page_referenced retval and I don't
like the wipe_page_referenced concept. page_referenced should only be
called when we're in presence of VM pressure that requires
unmapping. And we should always re-add the page to active list head,
if it was found referenced as retval of page_referenced.
You are wrong here, for scalability reasons I explained
to you half a dozen times before :)
I agree with the rest of your email, though.
--
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/