Re: [Patch 1/2] GRU - function to generate chipset IPI values

[Andrew Morton]

On Thu, 03 Dec 2009 16:34:15 -0600
steiner@xxxxxxx wrote:

> From: Jack Steiner <steiner@xxxxxxx>
> 
> Create a function to generate the value that is written to the UV hub
> MMR to cause an IPI interrupt to be sent. The function will be
> used in the GRU message queue error recovery code that sends IPIs to
> nodes in remote partitions.
> 
> ...
>
> +static unsigned long uv_hub_ipi_value(int apicid, int vector, int mode)
> +{
> +	return (1UL << UVH_IPI_INT_SEND_SHFT) |
> +			((apicid) << UVH_IPI_INT_APIC_ID_SHFT) |
> +			(mode << UVH_IPI_INT_DELIVERY_MODE_SHFT) |
> +			(vector << UVH_IPI_INT_VECTOR_SHFT);
> +}

You've taken care to avoid a shift overflow of "1", but not of
`apicid', `vector' and `mode'.

Maybe the compiler does that, I forget.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/