Re: [PATCH] pata_hpt3x2n: fix overclocked MWDMA0 timing

From: Jeff Garzik
Date: Thu Dec 03 2009 - 15:56:59 EST


On 11/27/2009 02:47 PM, Sergei Shtylyov wrote:
Hello, I wrote:

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
---
Sergei, XFER_UDMA_5 timing also looks suspicious,
please take a look when you have a minute, thanks.

Yeah, but it's the same as XFER_UDMA_4, so actually underclocked...
However, it matches what the HPT371N datasheet and the vendor drivers
have. The 'hpt366' driver uses more speedy mode, with 22.5 ns cycle. ;-)

I have just verified: this driver has always used this timing
historically, at least for HPT372+ chips.

Could you clarify which "this timing" you are referring to? :) I never saw an Acked-by on this one.

Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/