Re: Should we use preempt_disable() in sleep_on_common()?

From: Dmitry Torokhov
Date: Thu Dec 03 2009 - 02:12:54 EST


On Wed, Dec 02, 2009 at 11:07:46PM -0800, Arjan van de Ven wrote:
> On Thu, 3 Dec 2009 14:49:14 +0800
> liu pf <kernelfans@xxxxxxxxx> wrote:
>
> > Hi:
> >
> > I am puzzled with the following scenario. Could anyone enlighten me?
>
>
> sleep_on family of APIs is very racy and just cannot be used correctly;
> I'm not surprised that there's a preempt race in it, but trust me, it's
> not the biggest race... never ever use these APIs!!!
>
>

BTW, why do we still have them? I checked couple and they don't seem to
be used...

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/