Re: Bug (minor): microcode_intel.c applies updates to hyperthreadedcores

[Arjan van de Ven]

On Wed, 02 Dec 2009 23:06:19 -0500
Michael Breuer <mbreuer@xxxxxxxxxx> wrote:

> According to spec, microcode should only be applied to actual cores.
> As things are currently structured, looks like the fix would be in
> microcode_core.c. I don't think changing the loop to look for cores
> vs. cpu's would affect anything adversely, but honestly am not
> familiar enough with this code or other cpu types to be sure.
> 

isn't this

for each (logical) cpu
   check microcode version of the cpu
   if too old, apply microcode

the 2nd pair of a hyperthreading pair will never see the 'too old' case
happen...


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/