Re: Pull request for MIPS-specific driver bits

From: Ralf Baechle
Date: Wed Dec 02 2009 - 19:02:04 EST


On Wed, Dec 02, 2009 at 03:46:08PM -0800, Linus Torvalds wrote:

> On Tue, 1 Dec 2009, Ralf Baechle wrote:
> >
> > Please pull them from
> >
> > git://ftp.linux-mips.org/pub/scm/upstream-linus.git upstream
>
> There are no driver updates there. It looks like you overwrote that branch
> with your other MIPS build fixes that you had a separate pull request for.

Correct - but that pull request was obsolete anyway as one of the driver
patches had independentaly submitted to both me and gregkh and you pulled
Greg's version yesterday.

I spun a new tree which again is at:

git://ftp.linux-mips.org/pub/scm/upstream-linus.git upstream

Please pull, thanks!

Ralf

commit 0fdd07f77fd9cc6a7d49076793daef06ea5d8f13
Author: Julia Lawall <julia@xxxxxxx>
Date: Sun Aug 9 11:42:32 2009 +0200

VIDEO: Correct use of request_region/request_mem_region

request_region should be used with release_region, not request_mem_region.

Geert Uytterhoeven pointed out that in the case of drivers/video/gbefb.c,
the problem is actually the other way around; request_mem_region should be
used instead of request_region.

The semantic patch that finds/fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r1@
expression start;
@@

request_region(start,...)

@b1@
expression r1.start;
@@

request_mem_region(start,...)

@depends on !b1@
expression r1.start;
expression E;
@@

- release_mem_region
+ release_region
(start,E)
// </smpl>

Signed-off-by: Julia Lawall <julia@xxxxxxx>
Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>

commit dbf763a2f1c117cfe45bbbd2c874a150f0e0900b
Author: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
Date: Thu Sep 3 22:59:01 2009 +0900

SPI: spi_txx9: Fix bit rate calculation

TXx9 SPI bit rate is calculated by:
fBR = (spi-baseclk) / (n + 1)
Fix calculation of min_speed_hz, max_speed_hz and n.

Signed-off-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>

drivers/spi/spi_txx9.c | 13 ++++++-------
drivers/video/gbefb.c | 2 +-
2 files changed, 7 insertions(+), 8 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/