Re: avoiding duplicate icache flushing of shared maps on nommu

From: Mike Frysinger
Date: Wed Dec 02 2009 - 17:41:56 EST


On Wed, Dec 2, 2009 at 09:15, David Howells wrote:
> Mike Frysinger wrote:
> + Â Â Â Â Â Â Â flush_icache_range(region->vm_start,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âregion->vm_end - region->vm_start);
> - Â Â Â Â Â Â Â flush_icache_range(result, result + len);

actually, there's one typo here. you want:
flush_icache_range(region->vm_start, region->vm_end);

it doesnt crash on blackfin systems as addresses not in icache get
nopped, but it was causing large delays on exec mappings. i thought
this was due to the nic on the board i was using as it's hitting some
weird pauses by itself.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/