Re: [PATCH 00/13] drivers/block/floppy.c: More cleanups

[Stephen Hemminger]

On Tue,  1 Dec 2009 22:07:40 -0800
Joe Perches <joe@xxxxxxxxxxx> wrote:

> Might as well make it cleaner...
> 
> Joe Perches (13):
>   drivers/block/floppy.c: Remove macro LOCK_FDC
>   drivers/block/floppy.c: Add debug_dcl(...) macro
>   drivers/block/floppy.c: Remove [U]CLEARF, [U]SETF, and [U]TESTF macros
>   drivers/block/floppy.c: Remove most uses of CALL and ECALL macros
>   drivers/block/floppy.c: remove [_]COPYIN [_]COPYOUT and ECALL macros
>   drivers/block/floppy.c: remove macros CALL, WAIT and IWAIT
>   drivers/block/floppy.c: convert int 1/0 to bool true/false
>   drivers/block/floppy.c: Move leading && and || to preceding line
>   drivers/block/floppy.c: remove #define DEVICE_NAME "floppy"
>   drivers/block/floppy.c: Convert int initialising to bool initialized
>   drivers/block/floppy.c: Add function is_ready_state
>   drivers/block/floppy.c: Readd SunOS eject cmd comment
>   drivers/block/floppy.c: Remove unnecessary return and braces
> 
>  drivers/block/floppy.c |  410 ++++++++++++++++++++++++------------------------
>  1 files changed, 208 insertions(+), 202 deletions(-)
> 

I like seeing it as individual patches like this, but the first batch
starts after your huge patch. Why not split that one up as well.

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/