Re: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm()

From: Jie Zhang
Date: Wed Dec 02 2009 - 10:08:21 EST


On 12/02/2009 10:45 PM, David Howells wrote:
Mike Frysinger<vapier@xxxxxxxxxx> wrote:

The mmu code uses the copy_*_user_page() variants in access_process_vm()
rather than copy_*_user() as the former includes an icache flush. This is
important when doing things like setting software breakpoints with gdb.
So switch the nommu code over to do the same.

Note that we may only really want to do an icache flush if the target region
is mapped executable somewhere. On the other hand, for debugging stuff on an
embedded board, it probably doesn't matter.

It is not checked before icache flush even for MMU. This is a place we can do some improvement. But it's not important for debugging.


Jie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/