Re: [tip:core/locking] locking, x86: Slightly shorten __ticket_spin_trylock()

[Jan Beulich]

>>> Avi Kivity <avi@xxxxxxxxxx> 02.12.09 15:36 >>>
>On 12/02/2009 04:25 PM, Jan Beulich wrote:
>>>>> Avi Kivity<avi@xxxxxxxxxx>  02.12.09 15:12>>>
>>>>>          
>>> Wouldn't 'u8 ret', as an additional argument be sufficient? gcc still
>>> ought to be able to use the same register for new and ret if we remove
>>> the early clobber.
>>>      
>> We can't (validly) remove the early-clobber, otherwise the compiler
>> would be permitted to use a register also used for addressing the lock
>> structure for "new".
>>    
>
>I meant for 'ret'.

But unless you drop the early-clobber on new, the compiler will have
to allocate another register, which I think is not desirable here.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/