Re: [tip:perf/core] tracing: Add DEFINE_EVENT(),DEFINE_SINGLE_EVENT() support to docbook

From: Ingo Molnar
Date: Wed Dec 02 2009 - 09:01:53 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Wed, 2009-12-02 at 10:42 +0000, tip-bot for Jason Baron wrote:
> > Commit-ID: 3a9089fd78367e2c6c815129030b790a0f5c2715
> > Gitweb: http://git.kernel.org/tip/3a9089fd78367e2c6c815129030b790a0f5c2715
> > Author: Jason Baron <jbaron@xxxxxxxxxx>
> > AuthorDate: Tue, 1 Dec 2009 12:18:49 -0500
> > Committer: Ingo Molnar <mingo@xxxxxxx>
> > CommitDate: Wed, 2 Dec 2009 09:57:37 +0100
> >
> > tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook
>
> Ug, I need more sleep, because I never noticed the "SINGLE" when I acked
> this :-p
>
> I thought the DEFINE_SINGLE_EVENT was still under discussion because it
> is a confusing name. I suggested to call it exactly what is was.
>
> DECLARE_CLASS_AND_DEFINE_EVENT()

Hm, that's a bit too long. How about 'DEFINE_CLASS_EVENT()' as a
compromise? It's similarly short-ish to TRACE_EVENT(), and it also
conveys the fact that we create both a class and an event there.

The full series would thus be:

DECLARE_EVENT_CLASS
DEFINE_EVENT
DEFINE_CLASS_EVENT

hm?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/