Re: [PATCH] mfd: twl4030: clarify the return value for read andwrite

[Felipe Balbi]

Hi,

On Wed, Dec 02, 2009 at 02:31:18PM +0100, ext Amit Kucheria wrote:
> @@ -298,10 +298,12 @@ int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
> 	ret = i2c_transfer(twl->client->adapter, twl->xfer_msg, 1);
> 	mutex_unlock(&twl->xfer_lock);
>
> -	/* i2cTransfer returns num messages.translate it pls.. */
> -	if (ret >= 0)
> -		ret = 0;
> -	return ret;
> +	/* i2c_transfer returns number of messages transferred */
> +	if (ret != 1) {
> +		pr_err("%s: twl4030_i2c_write failed to transfer all messages\n", DRIVER_NAME);

this line is over 80-chars

> +		return ret;
> +	} else

you should have {} here as well.

> +		return 0;
> }
> EXPORT_SYMBOL(twl4030_i2c_write);
>
> @@ -350,10 +352,13 @@ int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
> 	ret = i2c_transfer(twl->client->adapter, twl->xfer_msg, 2);
> 	mutex_unlock(&twl->xfer_lock);
>
> -	/* i2cTransfer returns num messages.translate it pls.. */
> -	if (ret >= 0)
> -		ret = 0;
> -	return ret;
> +	/* i2c_transfer returns number of messages transferred */
> +	if (ret != 2) {
> +		pr_err("%s: twl4030_i2c_read failed to transfer all messages\n", DRIVER_NAME);

over 80-chars

> +		return ret;
> +	}
> +	else

} else {

> +		return 0;

}

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/