Re: [PATCH] mmc: pxamci: call mmc_remove_host() before freeingresources

From: Daniel Mack
Date: Wed Dec 02 2009 - 06:03:36 EST


On Wed, Dec 02, 2009 at 08:50:44AM +0800, Eric Miao wrote:
> On Wed, Dec 2, 2009 at 1:17 AM, Daniel Mack <daniel@xxxxxxxx> wrote:
> > mmc_remove_host() will cause the mmc core to switch off the bus power by
> > eventually calling pxamci_set_ios(). This function uses the regulator or
> > the GPIO which have been freed already.
> >
> > This causes the following Oops on module unload.
> >

[...]

> >
> > Signed-off-by: Daniel Mack <daniel@xxxxxxxx>
> > Reported-by: Sven Neumann <s.neumann@xxxxxxxxxxxx>
> > Cc: Pierre Ossman <pierre@xxxxxxxxx>
> > Cc: Eric Miao <eric.y.miao@xxxxxxxxx>
> > Cc: linux-mmc@xxxxxxxxxxxxxxx
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Cc: stable@xxxxxxxxxx
> > ---
> >  drivers/mmc/host/pxamci.c |    4 ++--
>
> Looks like a correct fix to me.
>
> Acked-by: Eric Miao <eric.y.miao@xxxxxxxxx>

Would be good to still get this into .32 - who will take care of picking
this?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/