Re: [PATCH] perf_event: fix compile error

From: Ingo Molnar
Date: Wed Dec 02 2009 - 03:17:55 EST



* Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx> wrote:

> cc1: warnings being treated as errors
> builtin-probe.c: In function ???cmd_probe???:
> builtin-probe.c:163: error: unused variable ???fd???
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>
> ---
> tools/perf/builtin-probe.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
> index b5d15cf..64ea038 100644
> --- a/tools/perf/builtin-probe.c
> +++ b/tools/perf/builtin-probe.c
> @@ -160,7 +160,8 @@ static const struct option options[] = {
>
> int cmd_probe(int argc, const char **argv, const char *prefix __used)
> {
> - int i, j, fd, ret;
> + int i, j, ret;
> + int fd __used;
> struct probe_point *pp;

i think it's better to initialize it to -1 instead of turning off the
warning.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/