Re: [PATCH 16/24] HWPOISON: limit hwpoison injector to known pagetypes

[Ingo Molnar]

* Wu Fengguang <fengguang.wu@xxxxxxxxx> wrote:

> --- linux-mm.orig/mm/hwpoison-inject.c	2009-11-30 20:44:41.000000000 +0800
> +++ linux-mm/mm/hwpoison-inject.c	2009-11-30 20:58:20.000000000 +0800
> @@ -3,16 +3,41 @@
>  #include <linux/debugfs.h>
>  #include <linux/kernel.h>
>  #include <linux/mm.h>
> +#include <linux/swap.h>
>  #include "internal.h"
>  
>  static struct dentry *hwpoison_dir;
>  
>  static int hwpoison_inject(void *data, u64 val)
>  {

i'd like to raise a continuing conceptual objection against the ad-hoc 
and specialistic nature of the event injection in the 
mm/memory-failure*.c code. It should probably be using a standardized 
interface by integrating with perf events - as i outlined it before.

Where needed perf events should be extended - we can help with that. 
There's no point in having scattered pieces of incompatible (and 
user-ABI affecting) infrastructure all around the kernel.

Thanks,

	Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/