* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
On Tue, 2009-12-01 at 11:33 +0100, Ingo Molnar wrote:* Sripathi Kodi <sripathik@xxxxxxxxxx> wrote:Thing is, he's using the 'normal' fault injection code to do this, I see no objection to doing that.
Hi,Instead of this unacceptably ugly and special-purpose debugfs interface, please extend perf events to allow event injection. Some other places in the kernel (which deal with rare events) want/need this capability too.
This patch set adds fault injection for futex subsystem. It adds faults at places where reading/writing from user space can return EFAULT. This will be useful in testing any significant change to futex subsystem.
Yes - but its impact to the futex code is butt-ugly. That some facility is in the kernel does not mean it gets a free pass to be applied everywhere and anywhere.
An example of that would be tracepoints - there's no free pass to add tracepoints in new places and some maintainers elect to use different facilities. (or reject all current facilities)
If you want to redo the fault injection subsystem, then that's another story, but then we need to convert all of its users over.
What i want to see is sane code in futex.c. If we add hooks/callbacks i'd like it to be a complete solution helping a lot of usecases not some limited approach helping testability only.
Thanks,
Ingo