Re: [Patch] selinux: remove an unreachable line

[James Morris]

On Tue, 1 Dec 2009, Cong Wang wrote:

> > >  	default:
> > >  		return -EINVAL;
> > >  	}
> > > -	return -EINVAL;
> > >  }
> > 
> > I think it's better to remove the default case.
> > 
> 
> This is totally a personal taste, I think.
> Either is OK. James, any comments?

Leave the default: there but with a comment /* fall through */
instead of the return.



-- 
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/