Re: [PATCH 1/2] hw_random: core updates to allow more efficient drivers

[Ian Molton]

Rusty Russell wrote:

> But we're bikeshedding, so apply or revert.
> 
> 	/* A buffer which can hold any fundamental type: drivers are fussy. */
> 	static u8 rng_buffer[SMP_CACHE_BYTES < 8 ? 8 : SMP_CACHE_BYTES]
> 		__cacheline_aligned;

One nit - theres one driver where <24 bytes will be quite suboptimal.
I'd say pick 32 bytes, which is a common cachline size, too.

> Either way, both patches: Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Thanks!

-Ian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/