Re: [PATCH] change PCI nomenclature according to PCI-SIG

From: Jesse Barnes
Date: Mon Nov 30 2009 - 11:11:55 EST


On Sun, 29 Nov 2009 07:54:03 -0500
Jeff Garzik <jeff@xxxxxxxxxx> wrote:

> Next, IMO, you don't have any idea how maintainers will react to this
> patch, because you CC'd so few of them. People who perform tree-wide
> changes should take the time to CC __every__ relevant maintainer. If
> you are changing somebody's code, you should always let them know
> about it, and give them an opportunity to review the change.
> scripts/get_maintainer.pl can help with this.
>
> So, while the PCI maintainer might agree with the nomenclature
> change, he is not the most qualified person to state that your
> changes have no effect on drivers/edac/ppc4xx_edac.c, for example.

Honestly I'm not thrilled about it either. Given the large
downside of making many oustanding diffs conflict, I'm wary of these
sorts of changes in general. I suggested to Stefan that he just put
together one big patch to minimize that pain, but I didn't expect
something so huge (I was thinking it would be mainly limited to PCI
related files).

--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/