Re: [Patch] percpu: remove two suspicious break statements

[Tejun Heo]

On 11/30/2009 06:12 PM, Amerigo Wang wrote:
> These two break statements seem to be very suspicious,
> they are at the end of the statements inside the loop.
> Remove them.
> 
> Signed-off-by: WANG Cong <amwang@xxxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>

That actually is correct code.  It's checking whether the first
iteration covers the whole thing.  I thought the comment there

  /* quick path, check whether all pages are already there */

explained it but looking at it again, it definitely isn't enough
unless you already know what's going on there.  Can you please post a
patch to add the comment?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/