Re: [PATCH 03/41] VFS: Make lookup_hash() return a struct path

[Erez Zadok]

In message <1256152779-10054-4-git-send-email-vaurora@xxxxxxxxxx>, Valerie Aurora writes:

> @@ -1937,7 +1942,8 @@ EXPORT_SYMBOL(filp_open);
>   */
>  struct dentry *lookup_create(struct nameidata *nd, int is_dir)
>  {
> -	struct dentry *dentry = ERR_PTR(-EEXIST);
> +	struct path path = { .dentry = ERR_PTR(-EEXIST) } ;

I assume the compiler will initialize path.mnt to NULL.  Is NULL what you
want?  Even if the compiler guarantees it, I think you should either
explicitly init .mnt to NULL or leave a comment explaining what's going on
-- so no future code reader will think that this was omitted; a comment can
clarify your intentions more explicitly.

A struct path often requires both .mnt and .dentry to be set; it's not like,
say, inode_operations, where clearly some fields can be initialized to NULL
just fine.

Erez.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/