Re: [PATCH 1/2] hw-breakpoints: Use struct perf_event_attr todefine user breakpoints

[K.Prasad]

On Fri, Nov 27, 2009 at 04:55:53AM +0100, Frederic Weisbecker wrote:
> In-kernel user breakpoints are created using functions in which we pass
> breakpoint parameters as individual variables: address, length and
> type.
> 
> Although it fits well for x86, this just does not scale across
> archictectures that may support this api later as these may have
> more or different needs. Pass in a perf_event_attr structure
> instead because it is meant to evolve as much as possible into
> a generic hardware breakpoint parameter structure.
>

I suspect this further needs cleanup. Taking a quick look at all the
exported interfaces:

struct perf_event *
register_user_hw_breakpoint(struct perf_event_attr *attr,
                            perf_callback_t triggered,
                            struct task_struct *tsk);
struct perf_event *
modify_user_hw_breakpoint(struct perf_event *bp, struct perf_event_attr *attr,
                          perf_callback_t triggered,
                          struct task_struct *tsk);

void unregister_hw_breakpoint(struct perf_event *bp);

struct perf_event **
register_wide_hw_breakpoint(struct perf_event_attr *attr,
                            perf_callback_t triggered);

void unregister_wide_hw_breakpoint(struct perf_event **cpu_events);

It could be further improved to make them more intuitive and
symmetrical, for instance:

- Merge 'perf_callback_t triggered' with 'struct perf_event_attr' (it is
  very much an attribute of the breakpoint) (you may also want to rename
  'triggered' to something else...which is a pending suggestion from the
  community - 'triggered' indicates a boolean datatype and not a
  callback).

- Make register_<> always return 'struct perf_event *' (just like how
  unregister_<> always returns 'void').

- Both unregister_hw_breakpoint() and unregister_wide_hw_breakpoint()
  can accept 'struct perf_event *' as parameters.

Would you also like to rename register_wide_hw_breakpoint() to
register_kernel_hw_breakpoint() since a) It is used only for
kernel-space requests b) If a per-cpu kernel-space counter is desired in
future, register_wide_hw_breakpoint() name would shrink to
register_hw_breakpoint() causing ambiguity (user or kernel?) and
name-space collision.

Thanks,
K.Prasad

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/