Re: [PATCH] pata_it8213: MWDMA0 is unsupported

From: Bartlomiej Zolnierkiewicz
Date: Thu Nov 26 2009 - 13:09:52 EST


On Thursday 26 November 2009 06:23:18 pm Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> >>MWDMA0 timings cannot be met with the PIIX based controller
> >>programming interface.
>
> >>This change should be safe as this is how we have been doing
> >>things in IDE it8213 host driver for years.
>
> >>Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> >>---
> >>Verified with the documentation (similar case as with pata_efar).
>
> > Uhhh, no...
>
> > Too many damn drivers.
>
> > Too much damn duplication.
>
> > Too much damn subtle differences here and there.
>
> > The hardware is probably fine for MWMDA0 when it comes to pata_{efar,it8213},
> > it just not documented properly in the data sheet.
>
> How so with pata_efar? The active/recovery bitfields are still 2-bit
> wide, no?

Yes but when TIMEx bit is disabled we are using XFER_PIO_SLOW timings.

All data sheets including original Intel ones are a complete crap when it
comes to explicitly documenting this behavior.

--
Bartlomiej Zolnierkiewicz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/