Re: snd_usb_audio OOPS on MIPSEL - is that the mmap issue?

From: Andreas Mohr
Date: Thu Nov 26 2009 - 04:22:55 EST


Hi,

On Thu, Nov 26, 2009 at 10:09:04AM +0100, Takashi Iwai wrote:
> > This bug is really bad, Takashi Iwai and Ralf had a plan to add a
> > dma_mmap_coherent() function for 2.6.34 to fix it eventually.
> >
> > but for 2.6.33, perhaps that patch is a good temp solution(not enough
> > for the whole bug, but minimally) ;)
>
> I found a problem with that fix, namely, it doesn't distinguish the
> cases whether it's from dma_alloc_coherent() or directly from
> get_free_pages(). In the latter case, it'd do a wrong address
> conversion.
>
> I'll try to fix up this issue so that my dma_mmap_coherent()
> conversion can be merged more smoothly in the ALSA core side, and
> report back.

Many thanks to both of you! I'll possibly try either the unmodified patch
or an updated version soon (unless I decide to yank that entire non-working
appliance to /dev/null for the near future, that is ;).

Andreas Mohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/