Re: [PATCH] cfq: Make use of service count to estimate the rb_keyoffset

[Jens Axboe]

On Thu, Nov 26 2009, Gui Jianfeng wrote:
> Hi Jens, Czoccolo
> 
> For the moment, different workload cfq queues are put into different
> service trees. But CFQ still uses "busy_queues" to estimate rb_key 
> offset when inserting a cfq queue into a service tree. I think this 
> isn't appropriate, and it should make use of service tree count to do 
> this estimation. This patch is for for-2.6.33 branch.

Makes sense, we've before discussed that using ->busy_queues isn't very
good, as it's not a stable count. service_tree count isn't that much
better, but for for-2.6.33 it does make more sense.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/