Re: [PATCH v4] k10temp: temperature sensor for AMD Family 10h/11hCPUs

[Andrew Morton]

On Tue, 24 Nov 2009 09:43:39 +0100
Clemens Ladisch <clemens@xxxxxxxxxx> wrote:

> This adds a driver for the internal temperature sensor of AMD Family 10h
> and 11h CPUs.
> 
> Signed-off-by: Clemens Ladisch <clemens@xxxxxxxxxx>
> ---
> v3: added 'force' parameter for CPUs with buggy sensor; more documentation
> v4: added max/crit values, other changes suggested by Jean Delvare

Pierre's happy now?

>
> ...
>
> +#define REG_HARDWARE_THERMAL_CONTROL	0x64
> +#define  HTC_ENABLE			0x00000001
> +
> +#define REG_REPORTED_TEMPERATURE	0xa4
> +
> +#define REG_NORTHBRIDGE_CAPABILITIES	0xe8
> +#define  NB_CAP_HTC			0x00000400

These definitions relate to register addresses within the AMD CPUs,
yes?  I wonder if these should be placed in some header file in
arch/x86/include/asm/ where other such things are described.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/