Re: [RFC,PATCH 14/14] utrace core

[Ingo Molnar]

* Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> Much better. But in this case please note that most of tracehooks just 
> do:
> 
> 		if (unlikely(task_utrace_flags(current) & SOME_EVENT))
> 			utrace_report_some_event();
> 
> I really don't understand why we shouldn't have (trivial!) helpers for 
> this. (As for naming - personally I do not care at all ;)

We prefer helpers in most such cases - especially when in the normal 
case the helper has no side effects - as here. Then we want to compress 
all such reporting/callback as much as possible.

Using helpers to abstract away functionality is one of the basic 
elements of writing clean kernel code.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/