Re: [PATCH V2]irq/core: Add a length limitation

[Thomas Gleixner]

On Wed, 25 Nov 2009, Liuweni wrote:

>  ---
> In this version, I modify the code by Ingo's suggestion, 
> and less code add. 
> The code will check the irqaction->name's length 
> and avoid Using too long name without any notice.
>
> --- a/kernel/irq/proc.c
> +++ b/kernel/irq/proc.c
> @@ -196,6 +196,8 @@ void register_handler_proc(unsigned int irq, struct irqaction *action)
>  	char name [MAX_NAMELEN];
>  	struct irq_desc *desc = irq_to_desc(irq);
>  
> +	WARN_ON(strlen(action->name) < MAX_NAMELEN);
> +

This is going to warn on every action->name which is actually used in
the kernel except for the ones which are too long.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/