Re: [PATCH 3/5] slab.c: remove branch hint

From: Pekka Enberg
Date: Wed Nov 25 2009 - 05:42:05 EST


Ingo Molnar kirjoitti:
That sounds odd to me. Can you see where the incorrectly predicted
calls are coming from? Calling kmem_cache_alloc_node() with node set
to -1 most of the time could be a real bug somewhere.

I think it could occur in too limited tests - the branch prediction looks 'wrong' in certain tests - while it's OK in general.

Is there some easy to run workload you consider more or less representative of typical SLAB patterns?

I can think of three main classes: VFS, SCSI, or network intensive applications and benchmarks tend to bring out the worst in SLAB. There are probably some interesting NUMA related things that I'm not really aware of.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/