Re: [PATCHv2 3/3] Define critical regulators as always_on

[Mark Brown]

On Wed, Nov 25, 2009 at 12:04:55PM +0200, Juha Keski-Saari wrote:

> +	if (pdev->id == TWL4030_REG_VIO ||
> +		pdev->id == TWL4030_REG_VDD1 ||
> +		pdev->id == TWL4030_REG_VDD2 ||
> +		pdev->id == TWL4030_REG_VPLL1 ||
> +		pdev->id == TWL4030_REG_VINTANA1 ||
> +		pdev->id == TWL4030_REG_VINTANA2 ||
> +		pdev->id == TWL4030_REG_VINTDIG)
> +		c->always_on = true;

This would be a bit clearer and much more idiomatic as a switch
statement.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/