Re: lockdep complaints in slab allocator

From: David Rientjes
Date: Tue Nov 24 2009 - 16:22:22 EST


On Tue, 24 Nov 2009, Peter Zijlstra wrote:

> > slqb still has a 5-10% performance regression compared to slab for
> > benchmarks such as netperf TCP_RR on machines with high cpu counts,
> > forcing that type of regression isn't acceptable.
>
> Having _4_ slab allocators is equally unacceptable.
>

So you just advocated to merging slqb so that it gets more testing and
development, and then use its inclusion in a statistic to say we should
remove others solely because the space is too cluttered?

We use slab partially because the regression in slub was too severe for
some of our benchmarks, and while CONFIG_SLUB may be the kernel default
there are still distros that use slab as the default as well. We cannot
simply remove an allocator that is superior to others because it is old or
has increased complexity.

I'd suggest looking at how widely used slob is and whether it has a
significant advantage over slub. We'd then have two allocators for
specialized workloads (and slub is much better for diagnostics) and one in
development.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/