Re: [Resend Patch] kexec: allow to shrink reserved memory

From: Cong Wang
Date: Tue Nov 24 2009 - 03:48:15 EST


Dan Carpenter wrote:
On Mon, Nov 23, 2009 at 04:37:02AM -0500, Amerigo Wang wrote:
[snip]
+size_t crash_get_memory_size(void);
[snip]
+static ssize_t kexec_crash_size_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ return sprintf(buf, "%lu\n", crash_get_memory_size());
+}

CC kernel/ksysfs.o
kernel/ksysfs.c: In function âkexec_crash_size_showâ:
kernel/ksysfs.c:106: warning: format â%luâ expects type âlong unsigned intâ, but argument 3 has type âsize_tâ


Patch below fixes this.

Andrew, could you please fold it in? Thanks!

diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c
index 5b9276b..3feaf5a 100644
--- a/kernel/ksysfs.c
+++ b/kernel/ksysfs.c
@@ -103,7 +103,7 @@ KERNEL_ATTR_RO(kexec_crash_loaded);
static ssize_t kexec_crash_size_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
- return sprintf(buf, "%lu\n", crash_get_memory_size());
+ return sprintf(buf, "%zu\n", crash_get_memory_size());
}
static ssize_t kexec_crash_size_store(struct kobject *kobj,
struct kobj_attribute *attr,