Re: [PATCH 4/5] pata: Update experimental tags

[Jeff Garzik]

On 11/18/2009 01:19 PM, Bartlomiej Zolnierkiewicz wrote:
> On Tuesday 17 November 2009 15:51:39 Alan Cox wrote:
> > Signed-off-by: Alan Cox<alan@xxxxxxxxxxxxxxx>
> > ---
> >
> >   drivers/ata/Kconfig |    8 ++++----
> >   1 files changed, 4 insertions(+), 4 deletions(-)
> >
> >
> > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> > index f2df6e2..36931e0 100644
> > --- a/drivers/ata/Kconfig
> > +++ b/drivers/ata/Kconfig
> > @@ -374,7 +374,7 @@ config PATA_HPT366
> >   	  If unsure, say N.
> >
> >   config PATA_HPT37X
> > -	tristate "HPT 370/370A/371/372/374/302 PATA support (Experimental)"
> > +	tristate "HPT 370/370A/371/372/374/302 PATA support"
> >   	depends on PCI&&  EXPERIMENTAL
> >   	help
> >   	  This option enables support for the majority of the later HPT
> > @@ -383,7 +383,7 @@ config PATA_HPT37X
> >   	  If unsure, say N.
> >
> >   config PATA_HPT3X2N
> > -	tristate "HPT 372N/302N PATA support (Experimental)"
> > +	tristate "HPT 372N/302N PATA support"
> >   	depends on PCI&&  EXPERIMENTAL
> >   	help
> >   	  This option enables support for the N variant HPT PATA
>
> Maybe they are 'stable' but when it comes to features they are behind hpt366
> (i.e. they lack PCI PM), which is also much cleaner than your drivers, easier
> to understand and much smaller..

That sounds like an ACK to Alan's patch, to me ;-)

A libata driver can be stable, yet not have all the features of drivers/ide.

That said, I do agree that libata drivers need to have the features 
found in the drivers/ide/ drivers.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/