Re: [RFC] char/mem: Honor O_SYNC over intelligent setting of uncached access

[Li Yang]

On Wed, Nov 18, 2009 at 6:41 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> Li Yang <leoli@xxxxxxxxxxxxx> writes:
>
> D> The original code will automatially set the page non-cacheable if the mmap'ped
>> address is not in kernel managed low memory.
>>
>> We already have O_SYNC flag to pass the cacheability settings. Â Therefore we should
>> honor the case that O_SYNC is delibrately not used. ÂFor example, it is useful to the
>> case that not all system memory is managed by Linux, and want to be mmaped cacheable.
>>
>> Not sure if there is anything out there depending on the previous behavior.
>
> Very likely there is. That change seems rather dangerous.
>
> If you wanted to do something like this you would need a long
> deprecation period with printks and format warnings. But most likely
> it's not worth it, what advantage does the change have?

The general advantage is that user has the true control of the page
cacheability through O_SYNC file open() flag.  For the previous way,
kernel might map memory as non-cacheable when it's not necessary.  One
most common use case is that, user could limit the memory managed by
kernel and mmap the memory manually.  But he can't make that VMA
cacheable.  The user should have a better idea than kernel if a
certain memory space is I/O or not when using mmap().

- Leo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/