Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to&proc_dointvec,

From: Ingo Molnar
Date: Sun Nov 15 2009 - 03:11:44 EST



* Am??rico Wang <xiyou.wangcong@xxxxxxxxx> wrote:

> On Sat, Nov 14, 2009 at 05:52:05PM -0800, Joe Perches wrote:
> >Seems to be a typo.
> >
>
> Well, in this case, proc_dointvec == &proc_dointvec,
> both of them are the same function pointer.
>
> But yes, &proc_dointvec looks more readable.
>
> >Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
>
> Acked-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>

(Cc:-ed Eric who is running the sysctl tree these days)

Almost everywhere in the kernel we use the shorter version, so all of
sysctl.c should eventually change to that variant.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/