Re: [PATCH] drivers/thermal/thermal_sys.c: fix strncmp tests

[Joe Perches]

On Fri, 2009-11-13 at 14:22 -0800, Andrew Morton wrote:
> On Mon, 09 Nov 2009 14:12:49 -0800
> Joe Perches <joe@xxxxxxxxxxx> wrote:
> 
> > Use strncmp(var, "foo", sizeof("foo") - 1)
> > not strncmp(var, "foo", sizeof("foo"))
> > 
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> > 
> > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> > index 4e83c29..c35d538 100644
> > --- a/drivers/thermal/thermal_sys.c
> > +++ b/drivers/thermal/thermal_sys.c
> > @@ -147,9 +147,9 @@ mode_store(struct device *dev, struct device_attribute *attr,
> >  	if (!tz->ops->set_mode)
> >  		return -EPERM;
> >  
> > -	if (!strncmp(buf, "enabled", sizeof("enabled")))
> > +	if (!strncmp(buf, "enabled", sizeof("enabled") - 1))
> 
> How about
> 
> 	if (!strcmp(buf, "enabled"))

Fine with me.

I think strncmp(foo, "bar", sizeof("bar"))
where foo has a trailing 0 should be
converted to strcmp(foo, "bar");



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/