Re: [PATCH 5/7 v6] hw-breakpoints: Rewrite the hw-breakpointslayer on top of perf events

[Frederic Weisbecker]

On Sun, Nov 08, 2009 at 06:24:46PM +0100, Jan Kiszka wrote:
> > +	 * care about the messed up debug address registers. But if
> > +	 * we have some of them active, restore the old state.
> > +	 */
> > +	if (__get_cpu_var(dr7) & DR_GLOBAL_ENABLE_MASK)
> 
> Looks good, just a minor remark: Would be cleaner to wrap this into an
> inline function, say hw_breakpoint_active(), to abstract the precise
> condition away from KVM.


Done :)

 
> > +		hw_breakpoint_restore();
> >  
> >  	set_bit(KVM_REQ_KICK, &vcpu->requests);
> >  	local_irq_enable();
> 
> Will see that I can give your series a try the next days, probably
> debugging qemu-kvm while running a guest that uses breakpoints. But I
> don't expect surprises.
> 
> Jan


Thanks!

You can find it at:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git
	tracing/hw-breakpoints



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/