Re: [PATCH 4/4] fs/qnx4: decrement sizeof size in strncmp

From: Julia Lawall
Date: Thu Nov 12 2009 - 05:05:57 EST


On Thu, 12 Nov 2009, Anders Larsen wrote:

> On 2009-11-12 08:49:44, Julia Lawall wrote:
> > As observed by Joe Perches, sizeof of a constant string includes the
> > trailing 0. If what is wanted is to check the initial characters of
> > another string, this trailing 0 should not be taken into account. If an
> > exact match is wanted, strcmp should be used instead.
>
> Good catch.
> However, in this case an exact match (with the string ".bitmap") is what
> is needed, so
>
> NAK
>
> Will you cook up a new patch changing strncmp to strcmp?

Sure.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/