Re: [PATCH] vfs: Add a trace point in the mark_inode_dirty function

From: Ingo Molnar
Date: Wed Nov 11 2009 - 06:15:58 EST



* Jeff Garzik <jeff@xxxxxxxxxx> wrote:

> On 11/11/2009 02:45 AM, Ingo Molnar wrote:
> >
> >* Jeff Garzik<jeff@xxxxxxxxxx> wrote:
> >
> >>On 11/11/2009 01:34 AM, Arjan van de Ven wrote:
> >>>Wu Fengguang<fengguang.wu@xxxxxxxxx> wrote:
> >>>>Maybe this is enough for POWERTOP, however for general use, the dirty
> >>>>type(data/metadata) and inode number may be valuable to some users?
> >>>
> >>>what can a user do with an inode number????
> >>
> >>Inode numbers have always been visible to userspace... IIRC, tar(1)
> >>uses the st_ino member of struct stat to detect hard links in certain
> >>cases. ls(1) displays inode numbers with -i, find(1) looks for them
> >>with -inum, ...
> >
> >Without an inode->vfs-name lookup/matching service it's of limited
> >utility
>
> Look in the quoted text for one such service... :)

I'm not sure i understand your point - do you really suggest using
find(1) to make traces readable?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/