Re: pci_find_parent_resource patch

[Jesse Barnes]

On Tue, 10 Nov 2009 07:57:47 -0800 (PST)
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> 	/* We can't insert a non-prefetch resource inside a
> prefetchable parent .. */ if (r->flags & IORESOURCE_PREFETCH)
> 		continue;
> 	/* .. but we can put a prefetchable resource inside a
> non-prefetchable one */ if (!best)
> 		best = r;
> 
>    instead. With the comments, it's now six lines instead of two, but
> it's conceptually simpler, and I _could_ have written it as two lines:
> 
> 	if ((res->flags & IORESOURCE_PREFETCH) && !best)
> 		best = r;	/* Approximating prefetchable by
> non-prefetchable */
> 
>    but I thought that was too damn subtle.
> 
> Feel free to use this long explanation as a commit message if you
> want,

Ok, I applied it to my linux-next tree.

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/